FEAT: Replace openai_objective_target initializer with explicit --target CLI parameter#1536
Merged
rlundeen2 merged 13 commits intomicrosoft:mainfrom Mar 24, 2026
Conversation
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
Co-authored-by: jsong468 <songjustin@microsoft.com>
Co-authored-by: jsong468 <songjustin@microsoft.com>
Co-authored-by: jsong468 <songjustin@microsoft.com>
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
reviewed
Mar 24, 2026
jsong468
approved these changes
Mar 24, 2026
Contributor
jsong468
left a comment
There was a problem hiding this comment.
lgtm! just wondering if we want get rid of some of the pyrit_scan params since they can be specified in the config file?
jsong468
reviewed
Mar 24, 2026
Co-authored-by: jsong468 <songjustin@microsoft.com>
Co-authored-by: jsong468 <songjustin@microsoft.com>
Co-authored-by: jsong468 <songjustin@microsoft.com>
Co-authored-by: jsong468 <songjustin@microsoft.com>
Co-authored-by: jsong468 <songjustin@microsoft.com>
rlundeen2
added a commit
to rlundeen2/PyRIT
that referenced
this pull request
Mar 26, 2026
…target The E2E tests were failing with exit code 2 because: 1. --database was removed from pyrit_scan CLI (PR microsoft#1536) 2. openai_objective_target initializer was deleted (PR microsoft#1536) Changes: - Add DEFAULT_OBJECTIVE_TARGET tag to TargetInitializerTags - Add openai_chat target config using generic OPENAI_CHAT_* env vars - Tag openai_chat as the default objective target in the registry - Update E2E test to use --target openai_chat, --initializers targets, and --config-file for InMemory database - Add unit tests for default objective target tagging Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how objective targets are specified when running scenarios. Instead of relying on the openai_objective_target initializer to set a default target, users now explicitly select a registered target by name via --target.
Changes: